- Posts: 9
- Thank you received: 0
Enhancement Request - Sorting
-
bryn
Inactive member - Topic Author
- New Member
Less
More
9 years 2 weeks ago #46112
by bryn
Enhancement Request - Sorting was created by bryn
Hello,
I would like to quest an enhancement to the Hot Swipe Carousel Module.
It would be awesome if you could sort the display order of the slides!
I realize this is not a trivial request, and will understand if it is rejected, but there is no harm in asking.
Kind Regards,
Bryn
I would like to quest an enhancement to the Hot Swipe Carousel Module.
It would be awesome if you could sort the display order of the slides!
I realize this is not a trivial request, and will understand if it is rejected, but there is no harm in asking.
Kind Regards,
Bryn
Please Log in to join the conversation.
-
milos
Support Staff - Moderator
Less
More
- Posts: 6742
- Thank you received: 715
9 years 2 weeks ago #46113
by milos
Replied by milos on topic Enhancement Request - Sorting
Hello Bryn,
This is a good idea and we will look to implement it in the next version.
Thanks
This is a good idea and we will look to implement it in the next version.
Thanks
Please Log in to join the conversation.
-
milos
Support Staff - Moderator
Less
More
- Posts: 6742
- Thank you received: 715
9 years 5 days ago #46152
by milos
Replied by milos on topic Enhancement Request - Sorting
Hello again,
We added Slide Priority parameter for each slide. The slides with higher priority (lower value) are displayed before the slides with lower priority (higher value). In example, the slide with priority value 3 will be displayed before the slide with priority value 7.
Thank you for your suggestion.
Regards
We added Slide Priority parameter for each slide. The slides with higher priority (lower value) are displayed before the slides with lower priority (higher value). In example, the slide with priority value 3 will be displayed before the slide with priority value 7.
Thank you for your suggestion.
Regards
Please Log in to join the conversation.
-
bryn
Inactive member - Topic Author
- New Member
Less
More
- Posts: 9
- Thank you received: 0
8 years 11 months ago #46170
by bryn
Replied by bryn on topic Enhancement Request - Sorting
Hello,
Many many thanks for taking the time to do this. An elegant approach.
I finally had a chance to download and try this out,
Unfortunately, it introduced a new problem. Sorry.
The slides in my sideshow seemed to disappear. The div 'container' was present. It was if the slides were blank pictures. I tried to narrow it down a little further for you.
I noticed that the new module, and some new features/settings. I tried setting
Module Properties --> Slides on Screen - to each setting.
Module Properties --> Slide Width -- to 100%, and other settings.
Then I (Google Chrome) inspected the code, and saw an 'Invalid Property Value' warnings, on the following.
So in modules\mod_hot_swipe_carousel\tmpl\default.php, around line 60, I changed...
To...
That seemed to do the trick. So I do not think its getting slideWidth properly.
Also, in my tinkering, when I changed, Module Properties --> Slides on Screen, to each setting, it did not seem to make a difference in the CSS it outputted, so I think its ignore your If statement.
Once that was sorted, I was able to test the Slide Ordering, and that worked great!!!
Hope this all helps. And as I have a workaround, there is absolutely no rush on this.
Happy Holidays,
Bryn
Many many thanks for taking the time to do this. An elegant approach.
I finally had a chance to download and try this out,
Unfortunately, it introduced a new problem. Sorry.
The slides in my sideshow seemed to disappear. The div 'container' was present. It was if the slides were blank pictures. I tried to narrow it down a little further for you.
I noticed that the new module, and some new features/settings. I tried setting
Module Properties --> Slides on Screen - to each setting.
Module Properties --> Slide Width -- to 100%, and other settings.
Then I (Google Chrome) inspected the code, and saw an 'Invalid Property Value' warnings, on the following.
Code:
.hot_swipe_carousel_slides1 .gallery-cell {
width: ;
margin-right: ;
}
So in modules\mod_hot_swipe_carousel\tmpl\default.php, around line 60, I changed...
Code:
$doc->addStyleDeclaration( '
.hot_swipe_carousel_slides'.$uniqueid.' .gallery-cell {
width: '.$slideWidth.';
margin-right: '.$slideMargin.';
}
To...
Code:
$doc->addStyleDeclaration( '
.hot_swipe_carousel_slides'.$uniqueid.' .gallery-cell {
width: 100%;
margin-right: 0;
height: auto;
}
That seemed to do the trick. So I do not think its getting slideWidth properly.
Also, in my tinkering, when I changed, Module Properties --> Slides on Screen, to each setting, it did not seem to make a difference in the CSS it outputted, so I think its ignore your If statement.
Once that was sorted, I was able to test the Slide Ordering, and that worked great!!!
Hope this all helps. And as I have a workaround, there is absolutely no rush on this.
Happy Holidays,
Bryn
Please Log in to join the conversation.
-
milos
Support Staff - Moderator
Less
More
- Posts: 6742
- Thank you received: 715
8 years 11 months ago #46171
by milos
Replied by milos on topic Enhancement Request - Sorting
Hello,
Thank you for reporting that. I am afraid I can't reproduce the problem on my server. You said "It was if the slides were blank pictures.". What kind of pictures you selected actually and which size? Are you saying it is working normally with "ordinary" images but not working with "blank" images?
Thanks and Happy Holidays,
Milos
Thank you for reporting that. I am afraid I can't reproduce the problem on my server. You said "It was if the slides were blank pictures.". What kind of pictures you selected actually and which size? Are you saying it is working normally with "ordinary" images but not working with "blank" images?
Thanks and Happy Holidays,
Milos
Please Log in to join the conversation.
-
bryn
Inactive member - Topic Author
- New Member
Less
More
- Posts: 9
- Thank you received: 0
8 years 11 months ago #46177
by bryn
Replied by bryn on topic Enhancement Request - Sorting
Hello,
The pictures are standard jpg, and are 1920px by 700px.
All worked well in the previous version of mod_hot_swipe_carousel3x.zip
To explain 'blank' better, it is if the image of each slide, is being rendered OK, but with a width of 0px and a height of 0px. Or I believe it is the contain div just above the img, that has height and width of 0px.
I tested a quick way to reproduce the issue
1. Download the latest version of hot_luxury3x_hotstart.zip from your website & install.
2. Download and install the latest version of mod_hot_swipe_carousel3x.zip from your website
And you will see the problem on the home page, on the first instance of Hot Swipe Carousel.
Hope this helps.
And again, there is no urgency on this. Just wanted to let you know.
Cheers,
Bryn
The pictures are standard jpg, and are 1920px by 700px.
All worked well in the previous version of mod_hot_swipe_carousel3x.zip
To explain 'blank' better, it is if the image of each slide, is being rendered OK, but with a width of 0px and a height of 0px. Or I believe it is the contain div just above the img, that has height and width of 0px.
I tested a quick way to reproduce the issue
1. Download the latest version of hot_luxury3x_hotstart.zip from your website & install.
2. Download and install the latest version of mod_hot_swipe_carousel3x.zip from your website
And you will see the problem on the home page, on the first instance of Hot Swipe Carousel.
Hope this helps.
And again, there is no urgency on this. Just wanted to let you know.
Cheers,
Bryn
Please Log in to join the conversation.
Time to create page: 0.322 seconds